logo for basementcommunity

basement
community

wall of shame

we're giving away money holy shit!!! check out the "happy birthday post" which announces a community event, where you could win 50 bucks!

software Rate my CMS code

deleted_user

joined some time ago

avatar

deleted_user

joined some time ago

content has been deleted

posted 6/13/2023, 11:00 am

joined dec 4, 2022

avatar

ohhhh this is the gunch!

joined dec 4, 2022

looks nice! just from a basic run-through of the code, it looks like there's pretty minimal error handling for form data that doesn't exist. i suppose it might be on the client and I just didn't see it, but the API routes seem to just assume everything is being passed correctly.

posted 6/16/2023, 5:27 pm

deleted_user

joined some time ago

avatar

deleted_user

joined some time ago

content has been deleted

posted 6/18/2023, 1:26 am

joined dec 4, 2022

avatar

ohhhh this is the gunch!

joined dec 4, 2022

i don't think it's necessarily required for you to add it to your server code - maybe if you eventually wanted to make the API a separate offering, it would be handy then. but really that's up to you.

i think more generally, server code should be the source of truth of the requirements of form fields, and any front-end validation is sugar on top.

posted 6/18/2023, 3:57 am

software Rate my CMS code